gh-142461: Move misplaced NEWS entries to an appropriate section #143392
Conversation
bedevere-app
bot
added
awaiting review
docs
Misc/NEWS.d/3.12.0a1.rst
Outdated
| .. gh-issue: 95185 | ||
| .. nonce: ghYTZx | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
This change is wrong, it was fixing the parser?
There was a problem hiding this comment.
thanks for pointing out.
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
astis a core module,- import machinery is a core component
Misc/NEWS.d/3.12.0a1.rst
Outdated
| .. gh-issue: 93351 | ||
| .. nonce: 0Jyvu- | ||
| .. section: Core and Builtins | ||
| .. section: Library |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Misc/NEWS.d/3.12.0a1.rst
Outdated
| .. gh-issue: 94869 | ||
| .. nonce: eRwMsX | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
This is a core and built-in. Other changes to ast are Library because they affect the pure python part of ast.parse.
|
@serhiy-storchaka Thanks for the review, I’ve applied the suggested change. I’ll also open a separate issue about |
|
In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits. When the PR is merged, everything will be squashed into a single commit. Also, do not click the "Update branch" button without a good reason because it notifies everyone watching the PR that there are new changes, when there are not, and it uses up limited CI resources. |
|
Thanks for pointing this out, I’ll keep it in mind
I wasn’t aware of this before and I apologize for the unnecessary notification. |
Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
pythonGH-143392) (cherry picked from commit 72bacb0) Co-authored-by: Aniket <[email protected]>
|
Sorry, @Aniketsy and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-144039 is a backport of this pull request to the 3.14 branch. |
…on (GH-143392) (GH-144039) (cherry picked from commit 72bacb0) Co-authored-by: Aniket <[email protected]>
5 participants
This includes changes in 3.12 and 3.13